[GitHub] [spark] zhengruifeng commented on a diff in pull request #40535: [SPARK-42907][CONNECT][PYTHON] Implement Avro functions

2023-03-28 Thread via GitHub
zhengruifeng commented on code in PR #40535: URL: https://github.com/apache/spark/pull/40535#discussion_r1150299249 ## assembly/pom.xml: ## @@ -160,6 +160,12 @@ spark-connect_${scala.binary.version} ${project.version} + Review Comment:

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40535: [SPARK-42907][CONNECT][PYTHON] Implement Avro functions

2023-03-24 Thread via GitHub
zhengruifeng commented on code in PR #40535: URL: https://github.com/apache/spark/pull/40535#discussion_r1147254339 ## dev/sparktestsupport/modules.py: ## @@ -747,6 +747,7 @@ def __hash__(self): "pyspark.sql.connect.readwriter", Review Comment: thanks, let me have

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40535: [SPARK-42907][CONNECT][PYTHON] Implement Avro functions

2023-03-23 Thread via GitHub
zhengruifeng commented on code in PR #40535: URL: https://github.com/apache/spark/pull/40535#discussion_r1146040349 ## python/pyspark/sql/connect/avro/functions.py: ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40535: [SPARK-42907][CONNECT][PYTHON] Implement Avro functions

2023-03-23 Thread via GitHub
zhengruifeng commented on code in PR #40535: URL: https://github.com/apache/spark/pull/40535#discussion_r1146040349 ## python/pyspark/sql/connect/avro/functions.py: ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor