[GitHub] [spark] zhengruifeng commented on pull request #31889: [SPARK-34797][ML] Refactor Logistic Aggregator - support virtual centering

2021-03-23 Thread GitBox
zhengruifeng commented on pull request #31889: URL: https://github.com/apache/spark/pull/31889#issuecomment-805529574 @srowen @WeichenXu123 Thanks for reviewing! The only question is that should we backport it to 3.1? if it is not a correctness issue. -- This is an automated message f

[GitHub] [spark] zhengruifeng commented on pull request #31889: [SPARK-34797][ML] Refactor Logistic Aggregator

2021-03-18 Thread GitBox
zhengruifeng commented on pull request #31889: URL: https://github.com/apache/spark/pull/31889#issuecomment-802465203 friendly ping @srowen @WeichenXu123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] zhengruifeng commented on pull request #31889: [SPARK-34797][ML] Refactor Logistic Aggregator

2021-03-18 Thread GitBox
zhengruifeng commented on pull request #31889: URL: https://github.com/apache/spark/pull/31889#issuecomment-802462693 I also test using the two new agg in `LogisticRegressionSuite`, and all test passed except "multinomial logistic regression with intercept with L1 regularization": e