[GitHub] [spark] zhengruifeng commented on pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

2022-11-16 Thread GitBox
zhengruifeng commented on PR #38659: URL: https://github.com/apache/spark/pull/38659#issuecomment-1318017962 you may reformat the scala code by `./build/mvn -Pscala-2.12 scalafmt:format -Dscalafmt.skip=fase -Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl connector/connect`

[GitHub] [spark] zhengruifeng commented on pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

2022-11-14 Thread GitBox
zhengruifeng commented on PR #38659: URL: https://github.com/apache/spark/pull/38659#issuecomment-1314662296 @dengziming thanks for the contributions! I think we'd better apply Arrow batch instead of structs in this proto message. you may refer to https://github.com/apache/spar