[GitHub] [spark] zhengruifeng commented on pull request #41469: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1

2023-07-11 Thread via GitHub
zhengruifeng commented on PR #41469: URL: https://github.com/apache/spark/pull/41469#issuecomment-1630287197 @panbingkun it is weird since IIRC the CI in this PR passed. but, if this upgrade cause such large changes in generated codes, let's revert it for now to avoid big changes befo

[GitHub] [spark] zhengruifeng commented on pull request #41469: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1

2023-07-10 Thread via GitHub
zhengruifeng commented on PR #41469: URL: https://github.com/apache/spark/pull/41469#issuecomment-1630250621 @panbingkun I think this failure started before this PR got merged. https://github.com/apache/spark/actions/runs/5511781438/jobs/10047815050 does this upgrade cause

[GitHub] [spark] zhengruifeng commented on pull request #41469: [SPARK-43974][CONNECT][BUILD] Upgrade buf to v1.23.1

2023-07-10 Thread via GitHub
zhengruifeng commented on PR #41469: URL: https://github.com/apache/spark/pull/41469#issuecomment-1629977761 merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm