zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630579815
cc @grundprinzip would you mind also taking a look? It seems that we need
this PR to enable the python codegen
--
This is an automated message from the Apache Git Service.
To respo
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630402998
if we can not avoid codegen change, then i am fine to upgrade buf to latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630365221
>
yeah, this failure actually started before we upgrade buf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630344412
but i think we have pinned the version of protobuf
https://github.com/apache/spark/blob/d7bc6f5c7efd9dcb1e460657447d1a9ea8f03f62/.github/workflows/build_and_test.yml#L637
--
This
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630326822
@Hisoka-X now the buf version is `v1.20.0`, would you mind help checking
whether this migration still cause codegen changes?
--
This is an automated message from the Apache Git Se
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630299746
> Can we try revert the version of buf 1.23.1 and only updating the
`remote-plugins`? If don't need to change so much code, I think we can revert
buf version before code freeze
zhengruifeng commented on PR #41933:
URL: https://github.com/apache/spark/pull/41933#issuecomment-1630290786
@LuciferYang @panbingkun @Hisoka-X @HyukjinKwon
do you know what cause this large changes in generated codes? the upgrade to
v1.23.1? or this migration?
--
This is an autom
