[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-22 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-449571822 Let me give a shot to make it with ML instrumentation to show how it's going to look like. -

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-20 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-449199714 Like, if we fix https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-20 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-449198904 @mengxr, looks actually considered at here https://github.com/apache/spark/pull/23263#issuecomment-447885870. I also check

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-20 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-449187069 I'm not used to ML side so it needs a while to check .. Let me check and be back soon! -

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-19 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-448539534 retest this please This is an automated message from the Apache

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-17 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-448077102 Oh! let me take a look. This is an automated message from the Ap

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-17 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-447858692 To make Atlas work for my case, any case is fine. I just need to catch the events related with Pipeline and that's all.

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-17 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-447856497 Yes .. that's what I wanted to do and the previous change is really what it needs as is .. I can go back to the previous c

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-17 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-447780841 To be absolutely conservative, I can even add a configuration switch if anyone feels so. ---

[GitHub] HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

2018-12-17 Thread GitBox
HyukjinKwon commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline URL: https://github.com/apache/spark/pull/23263#issuecomment-447771837 I made the change smaller by only sending events at `Pipeline`s. So, it should really be conservative enough in terms of being in