Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/11746
Hi @vanzin, have any more comments on this? Do you think it can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/11746
Yeah, I should have made the logs consistent with interpolation.. another
time then - thanks @vanzin!!!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/11746
Look good. I'd have used interpolation in the log message instead of
concatenation, but it's not worth it to re-run tests just for that.
Merging to master.
---
If your project is set up
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63305/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63305/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63305/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/11746
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63294/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63294 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63294/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63294/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/11746
Thanks for the review @vanzin! Style issues have been fixed and renamed
'Launch' to 'Run' where appropriate.
---
If your project is set up for it, you can reply to this email and have your
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/11746
Looks sane to me, but needs some style updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63277/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63277/consoleFull)**
for PR 11746 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/11746
@vanzin would you mind taking a look at this if you have time? It had
gotten stagnant but I think it still has some value.
In addition to the shutdown hook, I think changing the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #63277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63277/consoleFull)**
for PR 11746 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60248/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #60248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60248/consoleFull)**
for PR 11746 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11746
**[Test build #60248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60248/consoleFull)**
for PR 11746 at commit
23 matches
Mail list logo
