Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/12983
In sklearn, we use `sklearn.six.moves` which makes `range` and `xrange` to
be used interchangeably. In Python3, both `range` and `xrange` would return a
`range` instance and in Py2, both `xrange`
Github user davies commented on the issue:
https://github.com/apache/spark/pull/12983
If the number of iteration is not huge, it does not matter to use range()
or xrange() in Python 2 (especially when you use it together with `for`).
That's said I'm not a fan of this change.
---
If
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/12983
This still makes the alias go the opposite way to the current code base.
However there are only 11 occurrences of that currently, and you indicate there
are 30 files in total that need some alias.
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12983
@srowen I update this PR according to your comment, and make it a small PR
just to add 'xrange <-> range' alias in files that dont have it.
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63160/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #63160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63160/consoleFull)**
for PR 12983 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #63160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63160/consoleFull)**
for PR 12983 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #63155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63155/consoleFull)**
for PR 12983 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63155/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #63155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63155/consoleFull)**
for PR 12983 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/12983
How about we make the smaller change, and call `xrange` in those files like
the rest of the code does (and add the reverse alias where needed)?
---
If your project is set up for it, you can reply
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12983
@srowen In Python2, `xrange` is more efficient than `range`.
This PR add 'range = xrange' in files like `python/pyspark/accumulators.py`
`python/pyspark/heapq3.py`
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/12983
Yeah I can see that point; the change is ultimately a no-op. I'm neutral on
it, not much a python person myself.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12983
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62458/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #62458 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62458/consoleFull)**
for PR 12983 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12983
**[Test build #62458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62458/consoleFull)**
for PR 12983 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12983
@MechCoder @srowen There is no prefermance diffence. There is only one
little difference: Py2 have 'xrange' and 'range', while Py3 only have 'range'.
So unifying all case to 'range' may be
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/12983
Let's close this for lack of follow up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/12983
Yes, @zhengruifeng what's the difference here? could you update or close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/12983
I don't really get the difference, could you please explain it to me..
The previous version renamed `range` in `Python3` to `xrange` and this pull
request does the same thing by renaming
Github user asfer commented on the issue:
https://github.com/apache/spark/pull/12983
Apart from the merge conflict, everything looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
24 matches
Mail list logo
