[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-12 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/13155 @hvanhovell maybe this broke the build? https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-branch-2.0-compile-maven-scala-2.10/310/ --- If your project is set up for

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-12 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13155 LGTM - merging to master/2.0 (will do a small follow-up) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13155 @frreiss PR looks good. It does need a little bit of work in the style department. I'll leave comments. Lemme know if you have time to address these; else I'll take over and do that chore

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13155 @hvanhovell Could you have a final look on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13155 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13155 **[Test build #3074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3074/consoleFull)** for PR 13155 at commit

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13155 **[Test build #3074 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3074/consoleFull)** for PR 13155 at commit

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread frreiss
Github user frreiss commented on the issue: https://github.com/apache/spark/pull/13155 Tests ran successfully on my machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-10 Thread frreiss
Github user frreiss commented on the issue: https://github.com/apache/spark/pull/13155 Updated changes are in. Running a full regression suite overnight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-09 Thread frreiss
Github user frreiss commented on the issue: https://github.com/apache/spark/pull/13155 @rxin I'll have an updated set of changes in tonight --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13155: [SPARK-15370] [SQL] Update RewriteCorrelatedScalarSubque...

2016-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13155 @frreiss did you have a chance to update this? We want to cut an RC asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your