[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-04 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13504 Merging to master and 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13504 LGTM other than that small comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59981/ Test PASSed. ---

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13504 **[Test build #59981 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59981/consoleFull)** for PR 13504 at commit

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/13504 [hash code profile](https://github.com/apache/spark/files/298642/hashcode.svg.zip) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13504 @rxin, I don't have the specific performance numbers handy but in an optimizer stress-test benchmark run by @ericl, these hashCode calls accounted for roughly 40% of the total CPU time and this

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59974/ Test PASSed. ---

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13504 **[Test build #59974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59974/consoleFull)** for PR 13504 at commit

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13504 **[Test build #59981 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59981/consoleFull)** for PR 13504 at commit

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59971/ Test PASSed. ---

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13504 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13504 **[Test build #59971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59971/consoleFull)** for PR 13504 at commit

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13504 Can you put some data about performance improvements on the pr description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13504: [SPARK-15762][SQL] Cache Metadata & StructType hashCodes...

2016-06-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13504 **[Test build #59974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59974/consoleFull)** for PR 13504 at commit