[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-09 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/13540 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60145/ Test PASSed. ---

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13540 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13540 **[Test build #60145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60145/consoleFull)** for PR 13540 at commit [`d1c00da`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13540 **[Test build #60145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60145/consoleFull)** for PR 13540 at commit [`d1c00da`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/13540 Thanks @BryanCutler @MechCoder @MLnick for the review. I just update the PR to make it as property. Regarding the pyspark docs, I think there's umbrella jira to parity scala mllib and pyspark mllib,

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/13540 We should make it a property On Tue, 7 Jun 2016 at 11:28, Manoj Kumar wrote: > LGTM as well. pending the nitpick by @BryanCutler > > > Not rel

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/13540 Also, yes we should actually look at copying docs from Scala side where appropriate. We can add that to the QA JIRAs for Python doc. On Tue, 7 Jun 2016 at 11:28, Manoj Kumar wrote:

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13540 LGTM as well. pending the nitpick by @BryanCutler Not related, but it's been a while since I hacked on Spark or PySpark but at some point do we need better docs for PySpark? I couldn't fi

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/13540 Good catch! Not too big of deal, but should this be a property? Otherwise, LGTM cc @MLnick --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13540 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60116/ Test PASSed. ---

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13540 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13540 **[Test build #60116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60116/consoleFull)** for PR 13540 at commit [`e5c11da`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13540: [SPARK-15788][PYSPARK][ML] PySpark IDFModel missing "idf...

2016-06-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13540 **[Test build #60116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60116/consoleFull)** for PR 13540 at commit [`e5c11da`](https://github.com/apache/spark/commit/e