Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/13685
Thanks, @squito @markhamstra !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13685
merged to master. Thanks @lw-lin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/13685
LGTM. Good work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13685
lgtm! will leave open for a bit to see if anyone else comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/13685
Addressed all comments. @squito would you take another look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61091/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61091/consoleFull)**
for PR 13685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61091/consoleFull)**
for PR 13685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61087 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61087/consoleFull)**
for PR 13685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61087/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61087 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61087/consoleFull)**
for PR 13685 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13685
thanks for the test and explanation @lw-lin ! That is a great walk through
and reproduction of the issue, nice use of the latches to trigger it.
:thumbsup: I have only very small comments,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61034/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61034/consoleFull)**
for PR 13685 at commit
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/13685
Hi @squito thanks for the comments!
> how you'd have a TaskKilledException, but without setting the task to
`killed`
This can be reproduced when, a task gets
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #61034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61034/consoleFull)**
for PR 13685 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13685
Hi @lw-lin . Your description makes sense, but I'm having trouble seeing
how you'd have a `TaskKilledException`, but without setting the task to killed.
Eg., `TaskSchedulerImpl.cancelTasks`, which
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60609/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #60609 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60609/consoleFull)**
for PR 13685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #60609 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60609/consoleFull)**
for PR 13685 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13685
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #3107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3107/consoleFull)**
for PR 13685 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #3107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3107/consoleFull)**
for PR 13685 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60570/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13685
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #60570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60570/consoleFull)**
for PR 13685 at commit
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/13685
I couldn't come up with good syntax to express something like
```scala
case e @ (_: TaskKilledException) | (_: InterruptedException if
task.killed) =>
...
```
So this patch
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13685
**[Test build #60570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60570/consoleFull)**
for PR 13685 at commit
32 matches
Mail list logo
