Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13704
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64658/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #64658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64658/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #64658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64658/consoleFull)**
for PR 13704 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13704
left some comment, let's go ahead and merge it after that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@liancheng Could you please review this since I resolved conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64594/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #64594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64594/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #64594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64594/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@liancheng Could you please review this?
cc: @cloud-fan , we are waiting for @liancheng 's review for a long time.
---
If your project is set up for it, you can reply to this email and have your
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
ping @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@liancheng would it be possible to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@liancheng Could you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13704
LGTM, cc @liancheng to take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@cloud-fan Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62570/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62570/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62570/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62538/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62538 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62538/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62538 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62538/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62530/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62530/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62530/consoleFull)**
for PR 13704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62504/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62504/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62504/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@cloud-fan I misunderstood your comment. Now, I think that I understand it
correctly and addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62239/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62239/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62239/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
Addressed a comment. Since the following code cannot pass information on
`valueContainsNull = false`, I use the current code.
```
def map(mapType: MapType): AttributeReference =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62178/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62178/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62178 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62178/consoleFull)**
for PR 13704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62159/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62159/consoleFull)**
for PR 13704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62155/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62155/consoleFull)**
for PR 13704 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62159/consoleFull)**
for PR 13704 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
Thanks again for your kindly reviews. I addresses both comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13704
LGTM, one last comment:
https://github.com/apache/spark/pull/13704/files#r70381491
BTW can you also update the PR description? e.g. we don't need to show the
difference of generated code
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62155/consoleFull)**
for PR 13704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62152/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #62152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62152/consoleFull)**
for PR 13704 at commit
58 matches
Mail list logo
