Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13803
Irrespective of people reading the guide, it'll at least be useful to point
out what is the expected behavior in a code review etc. But yeah automatic
style checks would be really cool.
---
If y
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13803
I have been thinking about the same thing - problem is people generally do
not read contribution guide :) if there is a way to get automatic style check
it would be good.
---
If your project i
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13803
Yeah - thanks for all the work in cleaning this up. One thing that i was
wondering is we could add some style guide checks or contribution guide rules
on how to maintain documentation. We can discu
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13803
Great! Thanks! Hopefully now docs are in much better shape.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13803
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60942/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13803
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13803
LGTM. Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13803
**[Test build #60942 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60942/consoleFull)**
for PR 13803 at commit
[`0bc74c3`](https://github.com/apache/spark/commit/
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13803
Thanks - rebuilt locally and the docs look good. Will merge after Jenkins
passes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13803
**[Test build #60942 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60942/consoleFull)**
for PR 13803 at commit
[`0bc74c3`](https://github.com/apache/spark/commit/0
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/13803
done - @family doesn't need to be one word so added "stat functions"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/13803
Other than the comment about the `family` link the rest of the changes look
good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
12 matches
Mail list logo
