Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13831
Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13831
>> it would be nice to test using purge actually does a purge
> None of the tests run on actual HDFS cluster, so I doubt that would be
possible without a lot more work...
hmm, yeah
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62104/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #62104 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62104/consoleFull)**
for PR 13831 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #62104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62104/consoleFull)**
for PR 13831 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13831
I'd like to get this in soon, so pending tests, I'll leave this open until
tomorrow and then push, unless I hear otherwise.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61991/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61991/consoleFull)**
for PR 13831 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61991/consoleFull)**
for PR 13831 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13831
> it would be nice to test using purge actually does a purge
None of the tests run on actual HDFS cluster, so I doubt that would be
possible without a lot more work...
---
If your project
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13831
minor comments andrequest for some extra tests, but overall looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13831
it would be nice to test using purge actually does a purge, ie nothing is
in the trash afterwards. I don't see any easy way to do that, though -- maybe
using
Github user squito commented on the issue:
https://github.com/apache/spark/pull/13831
you could avoid changing all the callsites by adding a default of `purge =
false`, but I'm guessing that is discouraged in the sql code (since eg. there
is not default for `ignoreIfNotExists`).
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61859/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61859/consoleFull)**
for PR 13831 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61859/consoleFull)**
for PR 13831 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61406/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61406 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61406/consoleFull)**
for PR 13831 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61406/consoleFull)**
for PR 13831 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61004/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61004/consoleFull)**
for PR 13831 at commit
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/13831
@vanzin Thank you for the PR. I probably will not be able to review it
until we get 2.0 out. Will take a look after the release.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #61004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61004/consoleFull)**
for PR 13831 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13831
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60987/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #60987 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60987/consoleFull)**
for PR 13831 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13831
**[Test build #60987 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60987/consoleFull)**
for PR 13831 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13831
@andrewor14 @yhuai not sure who should review this?
Also, using a parameter with a default value might avoid some of the noise,
but I didn't see that approach used anywhere else in these
33 matches
Mail list logo