Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61173/consoleFull)**
for PR 13847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61168/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61168 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61168/consoleFull)**
for PR 13847 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61168 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61168/consoleFull)**
for PR 13847 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
I'm now checking failed tests...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61093/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61093/consoleFull)**
for PR 13847 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61093/consoleFull)**
for PR 13847 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13847
yea we should improve the type check of `CollectSet`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
Thx, good direction. The current master doesn't throw any exception in an
analyzer when map-typed data are passed into `collect_set`/`collect_list`.
Probably, should we check the case in there?
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13847
I think we don't need to implement `equals` and `hashCode` for map type, as
map type doesn't support equality and ordering by design, see
https://issues.apache.org/jira/browse/SPARK-9415
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #3126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3126/consoleFull)**
for PR 13847 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #3126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3126/consoleFull)**
for PR 13847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61053/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61053 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61053/consoleFull)**
for PR 13847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61053 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61053/consoleFull)**
for PR 13847 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61052/consoleFull)**
for PR 13847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61052/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61052/consoleFull)**
for PR 13847 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
At least, we'd be better to leave comments for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
Does the current implementation of `Vector.hashCode` have enough
performance? If so, it's okay to follow the impl. to me.
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13847
The performance of `hashCode()` should be pretty good in this case, and
this implementation is inline with the ones used in all other `Unsafe*` objects
(MurMurHash). I'd rather be consistent. If
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/13847
Do we need to hash all values? This could be a performance issue if
`hashCode` is called frequently on very large arrays.
Story: MLlib had some performance issues caused by
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61038/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13847
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61038/consoleFull)**
for PR 13847 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61041/consoleFull)**
for PR 13847 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
okay, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
okay, I'm fixing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13847
Yeah you are right about `UnsafeArrayData` (my bad).
I would take the same approach as `UnsafeRow`.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
aha, yes. It'd better to take the same approach in `UnsafeRow`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/13847
It seems `UnsafeArrayData` already has its own `equals` and hashCode`.
Currently, spark doesn't compare unsafe MapData though, I think this might
cause implicit bugs.
---
If your project is
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13847
You could also just also use the approach taken in `UnsafeRow`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13847
@maropu I think you also need to add these methods to `UnsafeArray` for
this to work.
Where in the spark code base do we compare two (unsafe) `MapData` objects?
Or are you comparing
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13847
**[Test build #61038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61038/consoleFull)**
for PR 13847 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13847
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
40 matches
Mail list logo
