Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13858
LGTM. Merging to master and 2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13858
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13858
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61371/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13858
**[Test build #61371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61371/consoleFull)**
for PR 13858 at commit
[`ee4708d`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13858
**[Test build #61371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61371/consoleFull)**
for PR 13858 at commit
[`ee4708d`](https://github.com/apache/spark/commit/e
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13858
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
I opted to force push a cleaned up version, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13858
You can always revert the commits in question and push, which become new
commits, but that's fine. They're all squashed in the end. You can also
manually squash and force-push if you like.
---
If y
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
Ugh, I just saw that I accidentally merged in some other PRs... I'm a bit
new to this, apologies. Any idea how I can amend this?
---
If your project is set up for it, you can reply to this email
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
My apologies @srowen, I missed the comment somehow! I refactored a little
bit to make it more obvious what's going on there (using `stripPrefix` as you
suggested).
---
If your project is set up
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13858
I had an outstanding comment from the previous PR too:
https://github.com/apache/spark/pull/13857#discussion_r68134544
---
If your project is set up for it, you can reply to this email and have your
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/13858
@tmagrino could you add a simple test here:
https://github.com/apache/spark/blob/282158914d89b35a3f85388cb20bd62215f4f589/core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala#L804
Github user tmagrino commented on the issue:
https://github.com/apache/spark/pull/13858
CCing some people who were involved in previous commits for this part of
the code, @tdas @zsxwing. Does this look good?
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13858
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61098/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13858
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13858
**[Test build #61098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61098/consoleFull)**
for PR 13858 at commit
[`b497dc9`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13858
**[Test build #61098 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61098/consoleFull)**
for PR 13858 at commit
[`b497dc9`](https://github.com/apache/spark/commit/b
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13858
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13858
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
19 matches
Mail list logo
