Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
Yeah, you'd branch from branch-2.0, cherry-pick your original PR, resolve
the conflicts as needed, and then open a new PR.
---
If your project is set up for it, you can reply to this email and have
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen OK, I think I can do that. Do I understand correctly, that I need
to clone 2.0, make the necessary changes and then make a new PR?
---
If your project is set up for it, you can reply to th
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
OK, if you're willing to go one more round and prepare a patch for 2.0, it
would be much appreciated. You're close to the change and I know several people
hit this with 2.0.0. I will revert my handiw
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen It seems that the issue is with the new version of `warehousePath`.
It did string replace `user.dir` in the path in the original 2.0.
`warehousePath` was simplified in master due to new `ge
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
It's weird. Some branch 2.0 tests fail in core, but with no visible error
anywhere. But I spotted this failure:
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-branch
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen Could you give me a link to the log of the failed 2.0 build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
This didn't work in branch-2.0. I'm going to investigate briefly and almost
certainly revert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
Merged to master, and to 2.0 after a weird conflict and then merge problem
(Github API isn't matching the status shown here?). I'll keep an eye on the
builds to make sure I did it right.
---
If you
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63430/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63430 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63430/consoleFull)**
for PR 13868 at commit
[`ea24b59`](https://github.com/apache/spark/commit/
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
OK will merge soonish if there are no further comments. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen Sure. I've addressed @vanzin 's comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63430 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63430/consoleFull)**
for PR 13868 at commit
[`ea24b59`](https://github.com/apache/spark/commit/e
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
@avulanov can you have one more look at Marcelo's last small comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
Any further comments, watchers? maybe worth implementing Marcelo's last
comments and then let's merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/13868
Looks good; I think some `toString` calls could be cleaned up (e.g.
`makeQualifiedPath` could return a String as far as I can see, don't need
`toString` to use a variable in an interpolated string, e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63222/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63222 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63222/consoleFull)**
for PR 13868 at commit
[`1b5b035`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63222/consoleFull)**
for PR 13868 at commit
[`1b5b035`](https://github.com/apache/spark/commit/1
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen @vanzin Thank you. I addressed your comments and fixed the
mentioned 4 tests from `DDLSuite.scala` that failed on Windows.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63172/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63172/consoleFull)**
for PR 13868 at commit
[`2b592b6`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63167/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63167 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63167/consoleFull)**
for PR 13868 at commit
[`c78da11`](https://github.com/apache/spark/commit/
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@shivaram @zsxwing Removed `toUri` and did rebase. 4 new tests from
`DDLSuite` fail. Need some more time to fix them.
@vanzin Could you please check that I don't break your change of `def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63172/consoleFull)**
for PR 13868 at commit
[`2b592b6`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #63167 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63167/consoleFull)**
for PR 13868 at commit
[`c78da11`](https://github.com/apache/spark/commit/c
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen Do you suggest to fix all occurrences of `file` as a constant
string or leave the patch as is?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61344/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61344/consoleFull)**
for PR 13868 at commit
[`f247423`](https://github.com/apache/spark/commit/
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
I used `makeQualifiedPath` from `SessionCatalog` to construct paths. It
uses hadoop's `Path` and `FileSystem`. Each attempt of path construction should
use this approach in order to be consistent w
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61344/consoleFull)**
for PR 13868 at commit
[`f247423`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61343 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61343/consoleFull)**
for PR 13868 at commit
[`90a413d`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61343/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61343 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61343/consoleFull)**
for PR 13868 at commit
[`90a413d`](https://github.com/apache/spark/commit/9
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
Hm, where we are conceptually dealing with a local file only, we should use
the File API. If some tests are making assertions about the path, really,
rather than full URI, then you can get that from
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61219/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61219/consoleFull)**
for PR 13868 at commit
[`fb50965`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61214/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61214/consoleFull)**
for PR 13868 at commit
[`a797fbe`](https://github.com/apache/spark/commit/
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
It seems that the root cause is that hadoop `Path.toUri` adds only `/` to
the beginning of the path but does not add `file:`. So, here and there in the
code we observe in-place concatenations of `f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61219/consoleFull)**
for PR 13868 at commit
[`fb50965`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61214/consoleFull)**
for PR 13868 at commit
[`a797fbe`](https://github.com/apache/spark/commit/a
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13868
This looks like the right direction. There are more instances of `file:`
used this way in the code, but only a few look like they might need a similar
treatment. `DDLSuite` sticks out, and in fact it
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13868
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61120/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61120/consoleFull)**
for PR 13868 at commit
[`40af9b4`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13868
**[Test build #61120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61120/consoleFull)**
for PR 13868 at commit
[`40af9b4`](https://github.com/apache/spark/commit/4
Github user avulanov commented on the issue:
https://github.com/apache/spark/pull/13868
@srowen @rxin There was an issue with string replace that added another
slash that prevented unit test to succeed. Fixed this.
---
If your project is set up for it, you can reply to this email and
57 matches
Mail list logo
