[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13872 Thank you, @mengxr , @liancheng , and @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13872 Merged into master and branch-2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13872 Thank you, @rxin . I hope so, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13872 I think it'd be difficult to guarantee ordering all the time, but since the change is small we might as well take this tiny step to ensure stronger compatibility. --- If your project is set up for i

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13872 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/13872 @liancheng @rxin In the code, I didn't use UDF explicitly in a filter expression. It is like the following: ~~~ filter b > 0 set a = udf(b) filter a > 2 ~~~ and the o

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13872 My major concern is that even the reported case is "fixed" by this PR, in general user applications shouldn't rely on predicate evaluation order. Other than that, the change made in `CombineFilter

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61105/ Test PASSed. ---

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13872 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13872 **[Test build #61105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61105/consoleFull)** for PR 13872 at commit [`2b21fd7`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13872: [SPARK-16164][SQL] Update `CombineFilters` to try to con...

2016-06-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13872 For any conclusion, thank you for review, @mengxr and @liancheng ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje