[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2017-05-09 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/13906 I found a bug in the part of this rule which deals with `Aggregate`; see #17929 for the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Thank you for merging, @liancheng , @cloud-fan , and @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13906 Merged to master. @cloud-fan Sorry that I didn't notice your comment while merging it. We may address it in follow-up ones. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Hi, @rxin , @cloud-fan , @liancheng . It's ready for merging again. Thank you so much for being together with this PR! --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61598/ Test PASSed. ---

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61598/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61598/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 It's the exact same `Scala 2.10 match reachability build error` at previous https://github.com/apache/spark/commit/fda51f171450d03769242fa7829cbb8b6e0e627b . The solution is the

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Oh, please hold on merging this PR. Scala 2.10 reports some errors. I'll inform you again. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61581/ Test PASSed. ---

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61581/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13906 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Thank YOU, @cloud-fan ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61581/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13906 LGTM except some naming comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 The title and description of PR/JIRA are updated consistently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project