Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70570/testReport)**
for PR 13909 at commit
[`28df09f`](https://github.com/apache/spark/commit/28
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70570/testReport)**
for PR 13909 at commit
[`28df09f`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70570/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/13909
LGTM except for few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70578/testReport)**
for PR 13909 at commit
[`293b344`](https://github.com/apache/spark/commit/29
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70578/testReport)**
for PR 13909 at commit
[`293b344`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70578/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70584/testReport)**
for PR 13909 at commit
[`69d5e33`](https://github.com/apache/spark/commit/69
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70584/testReport)**
for PR 13909 at commit
[`69d5e33`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70584/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70606/testReport)**
for PR 13909 at commit
[`2556ba5`](https://github.com/apache/spark/commit/25
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70607 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70607/testReport)**
for PR 13909 at commit
[`34bff15`](https://github.com/apache/spark/commit/34
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70608 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70608/testReport)**
for PR 13909 at commit
[`4a0409a`](https://github.com/apache/spark/commit/4a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70606/testReport)**
for PR 13909 at commit
[`2556ba5`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70606/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70607/testReport)**
for PR 13909 at commit
[`34bff15`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70607/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70608 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70608/testReport)**
for PR 13909 at commit
[`4a0409a`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70608/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70614 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70614/testReport)**
for PR 13909 at commit
[`dcce4c5`](https://github.com/apache/spark/commit/dc
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
> Should use dataType.containsNull for allowNull?
no we shouldn't, `containsNull` is kind of an optimizing hint that
guarantees the value will not be null, and it's guaranteed by the sour
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13909
@cloud-fan Hmm, I agree that it's guaranteed by the source, but I thought
that's why we should use `containsNull` for `allowNull` to guarantee the value
will not be null when `containsNull == false`
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
@ueshin That will be a big mess if we validate the null here and there, I
think we should only do it at the source side. If we do not trust the source
side, there are a lot of other places that ne
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70614 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70614/testReport)**
for PR 13909 at commit
[`dcce4c5`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70614/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13909
@cloud-fan Hmm, I didn't mean we don't trust the source side.
Currently we DO validate the null regardless of `allowNull` value.
The difference by the `allowNull` is setting null or throwi
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
I think the validation logic should be consistent across the system, you
can't add the null check in `CreateArray` just because it's easy to do.
Currently we do null check based on `nullable` prop
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
Well I don't think we should waste time arguing this minor problem and
block this PR, how about we revert it and send a new PR to add it?
---
If your project is set up for it, you can reply to th
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13909
I see, I agree that we shouldn't block this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70636/testReport)**
for PR 13909 at commit
[`2f67ac2`](https://github.com/apache/spark/commit/2f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70640/testReport)**
for PR 13909 at commit
[`c986361`](https://github.com/apache/spark/commit/c9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70636/testReport)**
for PR 13909 at commit
[`2f67ac2`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70636/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70640/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13909
@cloud-fan I rethought after changing `allowNull` to `isMapKey`, and
finally I see what you said.
And we should revert the error message changes 4a0409a, right?
---
If your project is set u
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
yea we should! thanks for pointing this out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70657/testReport)**
for PR 13909 at commit
[`cfe2e3d`](https://github.com/apache/spark/commit/cf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70657/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13909
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70668/testReport)**
for PR 13909 at commit
[`cfe2e3d`](https://github.com/apache/spark/commit/cf
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #70668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70668/testReport)**
for PR 13909 at commit
[`cfe2e3d`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70668/
Test PASSed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/13909
LGTM
BTW, @kiszk have you updated the benchmark with newest change, especially
after the UnsafeArrayData change?
---
If your project is set up for it, you can reply to this email and have y
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61250/consoleFull)**
for PR 13909 at commit
[`37e4ce2`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61250/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61250/consoleFull)**
for PR 13909 at commit
[`37e4ce2`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61264 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61264/consoleFull)**
for PR 13909 at commit
[`681be95`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61264/consoleFull)**
for PR 13909 at commit
[`681be95`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61264/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61282/consoleFull)**
for PR 13909 at commit
[`4238268`](https://github.com/apache/spark/commit/4
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/13909
How much overhead we can reduce with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61282/consoleFull)**
for PR 13909 at commit
[`4238268`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61282/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61285 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61285/consoleFull)**
for PR 13909 at commit
[`c2da5bd`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13909
**[Test build #61285 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61285/consoleFull)**
for PR 13909 at commit
[`c2da5bd`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61285/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13909
@viirya I should have a benchmark. When
https://github.com/apache/spark/pull/13758 is merged and
https://issues.apache.org/jira/browse/SPARK-16223 is solved, I will prepare
benchmark result.
---
If
201 - 273 of 273 matches
Mail list logo
