Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/13972
@mengxr Sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
Other example snippets in the SQL programming guide will be updated in
follow-up PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/13972
@yinxusen Do you have time to consolidate example files for
`mllib-data-types.md`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/13972
LGTM2. Merged into master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61519/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13972
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13972
**[Test build #61519 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61519/consoleFull)**
for PR 13972 at commit
Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/13972
@mengxr With this PR merged, I think we can also fix the [SPARK-13015
(mllib-data-types.md )](https://issues.apache.org/jira/browse/SPARK-13015) with
a consolidated example file.
---
If your
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
@yinxusen Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/13972
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13972
**[Test build #61519 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61519/consoleFull)**
for PR 13972 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
@yinxusen @mengxr Actually I found overlapped labelling is far more easier
than I expected earlier... So did it in the last commit.
Made the following experiment to illustrate the effect:
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
@yinxusen Thanks for the review! Also discussed with @mengxr. IIUC,
overlapped labels is most useful for handling imports, since sometimes we may
want to include one import line in multiple
Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/13972
One small matter is that we can't use intersecting labels, e.g.
```scala
// $example on:init_session$
some code
// $example on:build_session$
some code
// $example
Github user yinxusen commented on the issue:
https://github.com/apache/spark/pull/13972
I'll take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
@yinxusen Could you please help review this one since you're the original
author of this plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61467/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13972
**[Test build #61467 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61467/consoleFull)**
for PR 13972 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13972
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
Also cc @yhuai and @rxin.
The background here is that I'm going to extract snippets from actual
Scala/Java/Python/R source files rather than hard-code them in the SQL
programming guide,
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/13972
@mengxr Could you please help review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13972
**[Test build #61467 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61467/consoleFull)**
for PR 13972 at commit
23 matches
Mail list logo
