[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 Here it is for branch-2.0. https://github.com/apache/spark/pull/14131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 @cloud-fan thanks for merging! @yhuai I think the degree to which we want to add more tests also depend on how much we trust the library we are using. XPath (with Query) is almost as co

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 Thanks, merging to master! This doesn't merge clearly to 2.0, @petermaxlee can you submit a new PR against 2.0? thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13991 OK. Thanks. Then, it will be good to add more tests for cases that are not covered by those hive tests. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 BTW I have to say Hive's test coverage in this area is very spotty, so I don't actually think it's great to follow, but I used those. --- If your project is set up for it, you can reply to thi

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 Actually I created the unit tests based on those. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13991 As a follow-up task. Can you take a look at the following query files and add useful tests in your test? Thanks. ``` .//sql/hive/src/test/resources/ql/src/test/queries/clientpositive/describe_

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62070/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #62070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62070/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 I guess whatever generates that message is buggy? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 The latest result is `This patch does not merge cleanly.`, I just wanna double check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 @cloud-fan Jenkins already ran twice successfully before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #62070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62070/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13991 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #3175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3175/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #3175 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3175/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62000/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #62000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62000/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #62000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62000/consoleFull)** for PR 13991 at commit [`0c60d87`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61992/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61992/consoleFull)** for PR 13991 at commit [`fecc293`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61992/consoleFull)** for PR 13991 at commit [`fecc293`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13991 @hvanhovell can you take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61975/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61975/consoleFull)** for PR 13991 at commit [`24deac9`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61967/ Test FAILed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61967/consoleFull)** for PR 13991 at commit [`a86bc04`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61975/consoleFull)** for PR 13991 at commit [`24deac9`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61958/ Test FAILed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61958/consoleFull)** for PR 13991 at commit [`48311bb`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61957/ Test FAILed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61957/consoleFull)** for PR 13991 at commit [`d7d5f8d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61967/consoleFull)** for PR 13991 at commit [`a86bc04`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement all remaining xpath functio...

2016-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13991 **[Test build #61958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61958/consoleFull)** for PR 13991 at commit [`48311bb`](https://github.com/apache/spark/commit/4