[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/13996 I am closing this PR. This PR is superseded by #13998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 1. "When abstract class, you can later add defined methods which the users can override if needed, but does not break compatibility of existing implementations." This is what I'm taking issue wit

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/13996 Let me note down all the concerns clearly. 1. Compatibility with abstract class vs trait: Let me clarify. When abstract class, you can later add defined methods which the users can override if

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 See the linked pr https://github.com/apache/spark/pull/13998 for an example of what I'm proposing. I'll make sure the same thing works for consumer strategy and update that pr. If you le

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 So another concrete reason I'm against moving the strategy interfaces to java is that LocationStrategy is no longer sealed, so we lose exhaustivity checking on the cases. LocationStrate

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 I'll leave line comments about specific things, but my major overarching concern is about moving the interface to a Java abstract class. As far as I can tell, nothing being done in that cl

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61543/ Test PASSed. ---

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61543/consoleFull)** for PR 13996 at commit [`e5026f7`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 I've got concerns about this, please don't merge these refactorings until I get a chance to look at it today On Jun 30, 2016 6:32 AM, "Tathagata Das" wrote: > @koeninger

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61543/consoleFull)** for PR 13996 at commit [`e5026f7`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61541/ Test FAILed. ---

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61541/consoleFull)** for PR 13996 at commit [`345e1c3`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61541/consoleFull)** for PR 13996 at commit [`345e1c3`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61540/consoleFull)** for PR 13996 at commit [`39a26f3`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61540/ Test FAILed. ---

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61540/consoleFull)** for PR 13996 at commit [`39a26f3`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

Github user tdas commented on the issue: https://github.com/apache/spark/pull/13996 @koeninger @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or