Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14170
Agree. I'd rather fix a timezone for all tests. Some tests don't happen to
set one; I know some use GMT elsewhere. Well, it's an issue for another day, to
standardize it if it causes enough pain at s
Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/14170
Oh, I see what you are saying, although I'm not sure I agree with the
conclusion. Given that tests can run in parallel I don't think you actually
want to toggle back and forth between timezones.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14170
Yes, I got that, the problem is (potentially) in the _non_-SQL tests. If
nothing's failing today, probably is entirely fine in practice, but this could
have been made more robust while we're here.
Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/14170
I think thats where we are today. All query tests use LA and the harness
configures that. The problem before this PR was this one suite was setting LA
(due to its base class), and then UTC (due to
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14170
They should extend a test that explicitly sets that if so, or else it only
happens to be set because of test ordering. The issue really is that it gets
set for all remaining tests not in SQL. That co
Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/14170
All the tests in SQL are written to assume `Los_Angeles`, so I think this
is actually desired. Otherwise people have to configure their machine
specially to run spark tests.
---
If your project
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14170
It may be a secondary point, but `QueryTest` should reset the timezone like
the code being removed does. Right now it means that the timezone default stays
changed for any other tests in the JVM.
-
Github user marmbrus commented on the issue:
https://github.com/apache/spark/pull/14170
Thanks, merging to master and 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/14170
Created JIRA
[SPARK-16531](https://issues.apache.org/jira/browse/SPARK-16531)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
