[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-17 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 LGTM. Merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Sounds good to me! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-17 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 @felixcheung I plan to merge this into master but skip branch-2.0 as I dont want to introduce new test errors if we have another RC. Let me know if that sounds good --- If your project is set up

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62422/ Test PASSed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62422/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62422/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Agreed - this could be a bug in SQL/Hive, I'd be interested in digging into it a bit more later next week. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62419/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62419/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 I just realized that my local build was not using the hive profile. If this fails on Jenkins let's just go back to the original PR. Also I wonder if this is something we should notify the SQL

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62419/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 I didn't think that should be needed since SparkSession was created with enableHiveSupport = F. Let me try that too. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 Hmm ok - The only difference in the patch I tried out locally is that I had the `sleep` in the loop test case. Did you remove that for some other reason ? --- If your project is set up for it,

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Jenkins failed with: ``` 123456789a.bcdefghijklmnopqrstuvwxyzABCDS...EFGHIJKLMNOPQRSTUVW [Stage 61:> (0 + 0) / 2]

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62418/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62418/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62417/ Test FAILed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62417/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62418/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62417/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 No luck, but I push that change to see if it works better in Jenkins - is that what you are referring to? I'm consistently getting these errors: ``` Error in invokeJava(isStatic

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-16 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 So I just tried the setup where I only have `enableHiveMetastore=F` for the test case we are uncommenting and the `sparkR.session.stop` added to the other test files as in this PR. That seems to

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 I'd hit these errors fairly randomly if hive = T, even when stop is called ``` java.sql.SQLException: Failed to start database 'metastore_db' with class loader

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 Does the hive metastore not shutdown properly even if we do `sparkSession.stop()` in all the test files ? The reason I'm trying to avoid having `enableHiveMetastore=F` in most test files is that

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14177 Hive metastore didn't shutdown and restart cleanly was the original problem. it seemed to work better when SparkSession is starting with enableHiveSupport off. we do still have one in

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14177 Is there a reason why `enableHiveSupport = F` is required in all the test cases ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62226/consoleFull)** for PR 14177 at commit

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62226/ Test PASSed. ---

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14177: [SPARK-16027][SPARKR] Fix R tests SparkSession init/stop

2016-07-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14177 **[Test build #62226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62226/consoleFull)** for PR 14177 at commit