Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Sure. I've been looking that. It's on my list.
I'll make a JIRA issue and proceed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14235
@dongjoon-hyun can you also look into having stable identifiers for
gen_attr? Right now the golden files look really weird because gen_attr is used
more than once.
---
If your project is set up for
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Oh, thank you for merging, @rxin ! Also, thank you for review, @gatorsmile
and @liancheng .
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14235
Thanks - merging in master / 2.0.
I'm also merging this in 2.0 since it is a test only change and will reduce
merge conflicts.
---
If your project is set up for it, you can reply to thi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62493/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62493 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62493/consoleFull)**
for PR 14235 at commit
[`efaa4d0`](https://github.com/apache/spark/commit/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Jenkins is restarted, but the current last commit is efaa4d0 having the
passed Jenkins test. Could you review and merge this first if possible, @rxin ?
```
Test build #62469 has finishe
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62493 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62493/consoleFull)**
for PR 14235 at commit
[`efaa4d0`](https://github.com/apache/spark/commit/e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Hmm, HiveCompatibilitySuite has some dependency on `gen_attr_`. I reverted
the last attempt.
I will try as another PR as planed before.
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62487/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62487/consoleFull)**
for PR 14235 at commit
[`ee5b747`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62486 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62486/consoleFull)**
for PR 14235 at commit
[`244d013`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62486/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62487 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62487/consoleFull)**
for PR 14235 at commit
[`ee5b747`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62486/consoleFull)**
for PR 14235 at commit
[`244d013`](https://github.com/apache/spark/commit/2
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Hi, @rxin and @liancheng .
I will update this PR one more time. Please wait a moment.
I can use stable identifiers for `gen_attr`, too.
---
If your project is set up for it, you can re
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Thank you for review, @liancheng . Sure. Currently, it is only documented
in class doc. I think you are suggesting to have that in some HTML or
Wiki(Confluence). Did I understand your advice c
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/14235
LGTM.
One thing is that I feel most of the times the SQL comparison assertion may
fail due to reasonable internal changes that somehow affect SQL generation in
no harmful ways, and can be
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Thank you for guiding me in this PR, @rxin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62469/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62469/consoleFull)**
for PR 14235 at commit
[`efaa4d0`](https://github.com/apache/spark/commit/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Thank you, @rxin . By the way, the following test occurs two times
sequentially.
```
HiveSparkSubmitSuite.SPARK-8020: set sql conf in spark conf *** FAILED ***
(5 minutes, 0 seconds)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62469/consoleFull)**
for PR 14235 at commit
[`efaa4d0`](https://github.com/apache/spark/commit/e
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14235
Looks pretty good now. Just couple minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62450/consoleFull)**
for PR 14235 at commit
[`a9a1b00`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62450/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62448/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62450/consoleFull)**
for PR 14235 at commit
[`a9a1b00`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62448 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62448/consoleFull)**
for PR 14235 at commit
[`38f52ce`](https://github.com/apache/spark/commit/
35 matches
Mail list logo
