[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14256 I'm going to merge this in order to unblock the next 2.0 RC. Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14256 See also https://github.com/apache/spark/pull/14260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14256 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62508/ Test PASSed. ---

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14256 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14256 **[Test build #62508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62508/consoleFull)** for PR 14256 at commit

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/14256 @srowen @dongjoon-hyun, thanks for the clarification. Yep I had verified manually that the java version does not need any change before I opened this PR. --- If your project is set up for it, you

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14256 Oh indeed this change does implement exactly that, because it now calls the main overload with default args. LGTM, and this was the original intent of the earlier commit. I don't think the Java

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14256 SPARK-16613 is different I believe. You reported a `StackOverflowError` and indeed I can't figure out why the existing `pipe` methods just call themselves? It happened in

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14256 Hi, @lw-lin . This seems to resolve SPARK-16613 , too. Could you check that? If possible, please add SPARK-16613 into the title, too. --- If your project is set up for it, you can reply to

[GitHub] spark issue #14256: [SPARK-16620][CORE] Add back the tokenization process in...

2016-07-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14256 **[Test build #62508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62508/consoleFull)** for PR 14256 at commit