[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...

2016-07-31 Thread lovexi
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14415 Oops. I kind of messed up here. Going to open another PR for this. Close this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...

2016-07-31 Thread lovexi
Github user lovexi commented on the issue: https://github.com/apache/spark/pull/14415 @rxin I was trying to add a unit test for this feature. But the test sinks are not visible for `MetricsSystem` when it tries to register test sink classes since test sinks are hidden in test

[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...

2016-07-30 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14415 DId you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14415: [SPARK-16810] Refactor registerSinks with multiple const...

2016-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14415 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this