[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-09 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14519 I tested this locally and verified the serialization reduction. I posted the shuffle size comparison diagram in the PR description. I will merge this into master. Thanks for your review! @dbtsai

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/14519 LGTM. Will be nice to see the compassion of shuffle write size, and then will be ready to merge. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14519 @yanboliang Can you do a quick test to make sure the shuffle write size is the expected size? For example, in logistic regression only the gradient should be serialized which is an array of `numFeatu

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14519 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14519 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63362/ Test PASSed. ---

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14519 **[Test build #63362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63362/consoleFull)** for PR 14519 at commit [`287f153`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14519 **[Test build #63362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63362/consoleFull)** for PR 14519 at commit [`287f153`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14519 Let's put this into https://github.com/apache/spark/pull/14109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/14519 cc @sethah @dbtsai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14519 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63314/ Test PASSed. ---

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14519 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14519 **[Test build #63314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63314/consoleFull)** for PR 14519 at commit [`d152a3a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14519: [SPARK-16933] [ML] Fix AFTAggregator in AFTSurvivalRegre...

2016-08-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14519 **[Test build #63314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63314/consoleFull)** for PR 14519 at commit [`d152a3a`](https://github.com/apache/spark/commit/d