Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
closing in favor of https://github.com/apache/spark/pull/14676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
@gatorsmile we should support this, but you might have to add an explicit
cast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14539
How to specify `null` when we creating inline table?
```
sql(
"""
|create temporary view src as select * from values
|(201, null),
|(86,
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
@petermaxlee sure go ahead!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/14539
@hvanhovell do you mind me taking a look at this? I am running into an
issue in which I cannot use array() function to construct an array in inline
tables (only literals are allowed). I can try
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14539
@hvanhovell how about we make `InlineTable` an unresolved plan and resolve
it to `LocalRelation` in analyzer? It's weird that we don't have planner rules
for `InlineTable` and depend on optimizer
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
@cloud-fan I had an offline discussion with @rxin about this. His main
point was that a larger inline table would create an extremely unreadable plan.
So I came up with this.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63442/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63442 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63442/consoleFull)**
for PR 14539 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14539
@hvanhovell , I may miss something, why do we create this new `InlineTable`
instead of using `Union`? I think we can create a special `OneRowRelation`(e.g.
`UnfoldableOneRowRelarion`) in test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63442 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63442/consoleFull)**
for PR 14539 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63378/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63378/consoleFull)**
for PR 14539 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14539
Can we create some common function used by both union and this? It seems
like a pretty complicated plan to do this via union.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63378/consoleFull)**
for PR 14539 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63366/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63366/consoleFull)**
for PR 14539 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63366/consoleFull)**
for PR 14539 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63360/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63360/consoleFull)**
for PR 14539 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14539
fair enough, I think it's worth adding a negative test just to see what
we're dealing with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
@eyalfa I am a bit hesitant to add yet another almost pointless
`LogicalPlan` node to Catalyst, and certainly not one that is functionally
exactly the same as a `Union`. This would require us to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63360/consoleFull)**
for PR 14539 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14539
@hvanhovell don't you think that if you're already taking a stab at it,
it's better to introduce something like UnresolvedInlineTable with its own
resolution logic and type coercion, once it's
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63358/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
@eyalfa It is currently going to complain about Unions (if type coercion
fails).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63358/consoleFull)**
for PR 14539 at commit
Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14539
@hvanhovell in case of validation error, how will the error message look
like? will it mention inline-tables in any way, or is it just going to complain
about Union's requirements?
---
If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14539
**[Test build #63358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63358/consoleFull)**
for PR 14539 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14539
cc @cloud-fan @eyalfa
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
35 matches
Mail list logo
