Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
A new PR #14705 has been created from this one to merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #64004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64004/consoleFull)**
for PR 14558 at commit
[`2682719`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64004/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #64004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64004/consoleFull)**
for PR 14558 at commit
[`2682719`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #64002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64002/consoleFull)**
for PR 14558 at commit
[`71170e9`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #64002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64002/consoleFull)**
for PR 14558 at commit
[`71170e9`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64002/
Test FAILed.
---
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
Yes, I see. I was thinking about the case where the generic function has
but the corresponding method doesn't. In that case, if we add a dummy `...` at
the end of the argument list, its meaning is
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Does having ... in setGeneric forces CRAN checks to require @param there?
I think @mengxr point is that so long as the function definition also has
... we could have one @param at the fu
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
Yes, because the generic function and the method are grouped in the same
doc and we can only give one description for both of the `...`, we want the
actual meaning of them to be same.
---
If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Having two `... description` in the API doc can be confusing. It's hard to
tell which is for the generic and which is for the function. It would be more
confusing if their descriptions are somew
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
I am sure if it sounds like a reasonable temporary solution that we just
insert the `...` into the doc of some function definition, even though that
`...` may not really exist in that function. Tha
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
I realized later that by doing so, there will be at least two `...` in the
doc. However, they have slightly different meanings.
- generic function: it means "additional parameters"
- actual
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Thanks - I think this is reasonable.
Could we revisit if we are adding `...` a lot in function definition just
because the generic has it? Also those case we would be documenting `...` a
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/14558
@felixcheung I agree that we shouldn't put real documentation to
`generics.R`. I discussed with @junyangq offline and suggest the following:
1) If we have to put "..." in `setGeneric` (e.g.,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63830/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63830/consoleFull)**
for PR 14558 at commit
[`e5771a1`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63830/consoleFull)**
for PR 14558 at commit
[`e5771a1`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63651 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63651/consoleFull)**
for PR 14558 at commit
[`d2c1d64`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63654 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63654/consoleFull)**
for PR 14558 at commit
[`d2c1d64`](https://github.com/apache/spark/commit/d
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63651/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63654/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63654 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63654/consoleFull)**
for PR 14558 at commit
[`d2c1d64`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63620/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63620 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63620/consoleFull)**
for PR 14558 at commit
[`b87ba8f`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63620 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63620/consoleFull)**
for PR 14558 at commit
[`b87ba8f`](https://github.com/apache/spark/commit/b
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
sounds good. I think it's fine to put the `@param x a SparkDataFrame or a
Column or a GroupedData` in generics.R. It's not perfect, but putting that in
DataFrame.R isn't good either.
---
If y
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63554/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63554/consoleFull)**
for PR 14558 at commit
[`901edbb`](https://github.com/apache/spark/commit/
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
I agree and don't have a good answer right now either. In this PR, perhaps
we can just do minimal changes first, like add undocumented argument(s) only to
the class it belongs to (either generics o
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
@junyangq probably some overlap with your list (like `n` - should put that
in `count` instead of `nrow` - I think I commented on that above) - but feel
free to go ahead.
I haven't get a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63554/consoleFull)**
for PR 14558 at commit
[`901edbb`](https://github.com/apache/spark/commit/9
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
@felixcheung Have you looked at any of the warnings in the
[doc](https://docs.google.com/document/d/17fRlDLQa7IoB253MP6nm7dsvx1-GYMZBGyylX18ZaR0/edit)
yet? I can work on the remaining ones. :)
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63547/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63547/consoleFull)**
for PR 14558 at commit
[`901edbb`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63547/consoleFull)**
for PR 14558 at commit
[`901edbb`](https://github.com/apache/spark/commit/9
Github user junyangq commented on the issue:
https://github.com/apache/spark/pull/14558
@felixcheung Thank you very much for reviewing the PR. I thought you took
SPARK-16508 so I started working on this. Hope ours can complement each other...
---
If your project is set up for it, you
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Thank you for working on this. I've done a pass and added my notes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63423/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63423 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63423/consoleFull)**
for PR 14558 at commit
[`82e2f09`](https://github.com/apache/spark/commit/
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14558
Ah, I'm actually about half way though this as well, but let's review yours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14558
**[Test build #63423 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63423/consoleFull)**
for PR 14558 at commit
[`82e2f09`](https://github.com/apache/spark/commit/8
53 matches
Mail list logo
