[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2017-01-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14559 This is a pretty general issue for JDBC users. Could we backport it to Spark 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 @GraceH yeah you'll need a new PR. You can open it vs the same JIRA since these are fairly tightly related. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-17 Thread GraceH
Github user GraceH commented on the issue: https://github.com/apache/spark/pull/14559 Hi @srowen @rxin , sorry for late response. I have added the document part. https://github.com/GraceH/spark/commit/8360c2911b70aa628f8edba593e3764d3b07ca55 Shall I raise a new PR? --- If your

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-14 Thread GraceH
Github user GraceH commented on the issue: https://github.com/apache/spark/pull/14559 sure. Both are ok to me. will document those options. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 Oh... good point. I see the existing `truncate` option isn't documented either. Yes that should be done in `sql-programming-guide.md`. We can follow up on this one or make a new small issue for it.

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-13 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14559 Are the options here documented anywhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63666/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63664/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63664/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63675/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63675/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63675/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63662/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63667/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63667/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63667/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63666/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63666/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63664/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63662/ Test FAILed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63662/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread GraceH
Github user GraceH commented on the issue: https://github.com/apache/spark/pull/14559 Thanks all. I have added the unit test in JDBCWriterSuite. Any further comment, please feel free to let me know. BTW, or we can point the user to check JDBCOptions for further

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14559 +1 for both OK and not exposing `JDBCOptions`. I know it is slightly different but `CSVoptions` and `JSONOptions` would be good references to follow. --- If your project is set up for it, you

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14559 This is looking good. I'm not as familiar with the Python API but it doesn't seem like this needs a change in an API anywhere, Scala or Python. So I think this is OK. --- If your project is set up

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63587/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63587/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63587/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-10 Thread GraceH
Github user GraceH commented on the issue: https://github.com/apache/spark/pull/14559 @HyukjinKwon and @srowen, here is the initial proposal. Please let me know your comment. I will refine that with unit test later. BTW, the readwriter.py calls high level api of jdbc(url,

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63437/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63437/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63437/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63436/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63436/ Test FAILed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63436/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63427/ Test PASSed. ---

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63427/consoleFull)** for PR 14559 at commit

[GitHub] spark issue #14559: [SPARK-16968]Add additional options in jdbc when creatin...

2016-08-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14559 **[Test build #63427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63427/consoleFull)** for PR 14559 at commit