Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14620
@hvanhovell Thank you for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14620
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63912/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63912 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63912/consoleFull)**
for PR 14620 at commit
[`11bcb1d`](https://github.com/apache/spark/commit/
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14620
LGTM - pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63912 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63912/consoleFull)**
for PR 14620 at commit
[`11bcb1d`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63888/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63888 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63888/consoleFull)**
for PR 14620 at commit
[`36e049a`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63888 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63888/consoleFull)**
for PR 14620 at commit
[`36e049a`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63856/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63856/consoleFull)**
for PR 14620 at commit
[`0a8f21e`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63856/consoleFull)**
for PR 14620 at commit
[`0a8f21e`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63834/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63834/consoleFull)**
for PR 14620 at commit
[`a3068a7`](https://github.com/apache/spark/commit/
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14620
I've added test cases for all the methods in `ParserUtils`, and made two
small changes in the `ParserUtils` code:
1. Deleted function `command(stream: CharStream)`, merge both `command`
meth
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63834/consoleFull)**
for PR 14620 at commit
[`a3068a7`](https://github.com/apache/spark/commit/a
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14620
@hvanhovell I'm working on it, will try to add test cases for the remaining
methods:
1. `operationNotAllowed(message: String, ctx: ParserRuleContext)`;
2. `checkDuplicateKeys[T](keyPairs:
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14620
@jiangxb1987 are you also adding tests for the remaining `ParserUtils`
methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14620
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63725/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63725/consoleFull)**
for PR 14620 at commit
[`bf57b91`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14620
**[Test build #63725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63725/consoleFull)**
for PR 14620 at commit
[`bf57b91`](https://github.com/apache/spark/commit/b
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14620
@hvanhovell Thank you for your comments! Will do it as possible as I can.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14620
@jiangxb1987 thanks for doing this. I left a few comments. Any chance that
you also add tests for the remaining methods?
---
If your project is set up for it, you can reply to this email and hav
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/14620
@HyukjinKwon Thank you for checking!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
29 matches
Mail list logo
