Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
The issue is closed as 'LATER'. We can reopen the issue and the PR later if
needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
Do you think Apache Spark needs `window_functions.sql` in
`SQLQueryTestSuite`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65984/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65984 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65984/consoleFull)**
for PR 14623 at commit
[`00efad2`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65984 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65984/consoleFull)**
for PR 14623 at commit
[`00efad2`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65667/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65667 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65667/consoleFull)**
for PR 14623 at commit
[`425de3c`](https://github.com/apache/spark/commit/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Regenerate the answer set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65667/consoleFull)**
for PR 14623 at commit
[`425de3c`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65430/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65430 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65430/consoleFull)**
for PR 14623 at commit
[`4545837`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65430 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65430/consoleFull)**
for PR 14623 at commit
[`4545837`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65252/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65252/consoleFull)**
for PR 14623 at commit
[`04fe12d`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65252/consoleFull)**
for PR 14623 at commit
[`04fe12d`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65139/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65139/consoleFull)**
for PR 14623 at commit
[`679efb2`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65139/consoleFull)**
for PR 14623 at commit
[`679efb2`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65025/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65025 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65025/consoleFull)**
for PR 14623 at commit
[`0a28fd6`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #65025 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65025/consoleFull)**
for PR 14623 at commit
[`0a28fd6`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64982/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64982 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64982/consoleFull)**
for PR 14623 at commit
[`9cb28c1`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64982 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64982/consoleFull)**
for PR 14623 at commit
[`9cb28c1`](https://github.com/apache/spark/commit/9
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64964/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64964/consoleFull)**
for PR 14623 at commit
[`9cb28c1`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64964/consoleFull)**
for PR 14623 at commit
[`9cb28c1`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64873/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64873/consoleFull)**
for PR 14623 at commit
[`2b8f2cb`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64873/consoleFull)**
for PR 14623 at commit
[`2b8f2cb`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64570/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64570/consoleFull)**
for PR 14623 at commit
[`1229fdc`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64570/consoleFull)**
for PR 14623 at commit
[`1229fdc`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64497/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64497/consoleFull)**
for PR 14623 at commit
[`8977562`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64497 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64497/consoleFull)**
for PR 14623 at commit
[`8977562`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64357/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64357/consoleFull)**
for PR 14623 at commit
[`2cd34be`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64357/consoleFull)**
for PR 14623 at commit
[`2cd34be`](https://github.com/apache/spark/commit/2
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
Could you review this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64129/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64129/consoleFull)**
for PR 14623 at commit
[`186f28f`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #64129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64129/consoleFull)**
for PR 14623 at commit
[`186f28f`](https://github.com/apache/spark/commit/1
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Great! Thank you, @rxin .
Please give me advice about what you want to improve more. I will improve
in this direction.
---
If your project is set up for it, you can reply to this email an
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14623
Thanks - this is much better!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63994/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #63994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63994/consoleFull)**
for PR 14623 at commit
[`20604f6`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #63994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63994/consoleFull)**
for PR 14623 at commit
[`20604f6`](https://github.com/apache/spark/commit/2
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
Could you review this second try for `window_function.sql`? I simplified
the test for our eyeballs.
---
If your project is set up for it, you can reply to this email and have
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
I see what is your point. Then, I'll make a new one without consideration
`WindowQuerySuite.scala`. Thank you for guidance, @rxin !
---
If your project is set up for it, you can reply to this
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14623
@dongjoon-hyun I understand that the existing test didn't set a great
standard, but can you look at the data and query and come up with something a
lot shorter? The problem with the current cases is th
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
For `window_function.sql`, could you review again when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
If you think the direction of PR is not appropriate to your initial
intention, please let me know.
---
If your project is set up for it, you can reply to this email and have y
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63706/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14623
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #63706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63706/consoleFull)**
for PR 14623 at commit
[`4c202d3`](https://github.com/apache/spark/commit/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
What I wanted additionally here is to remove the legacy safely. You can
compare the result with the one of the legacy test suite side by side.
---
If your project is set up for it, you can re
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Hi, @rxin .
Now, it's less verbose but has the same content and result.
Could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #63706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63706/consoleFull)**
for PR 14623 at commit
[`4c202d3`](https://github.com/apache/spark/commit/4
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14623
Thanks - would be great to label the title with WIP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
Yes I'm still simplifying and making shareable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14623
Is this work in progress?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
At the first step, I moved the whole test case into here. I'm trying to
minimize this while keeping the same test coverage.
---
If your project is set up for it, you can reply to this email a
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14623
The following things are discussed so far in #14571 .
- Minimize the verbose test table.
- Make a sharable test table.
- What to do for legacy `WindowQuerySuite.scala` in `sql/hive`.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14623
**[Test build #63700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63700/consoleFull)**
for PR 14623 at commit
[`73a1ec9`](https://github.com/apache/spark/commit/7
80 matches
Mail list logo
