[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14661 Will do it soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14661 LGTM - pending test cases for SPARK-17099 and SPARK-17120. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14661 @gatorsmile could you add cases for both [SPARK-17099](https://issues.apache.org/jira/browse/SPARK-17099) and [SPARK-17120](https://issues.apache.org/jira/browse/SPARK-17120)? --- If your proje

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14661 @nsyca `filter.constraints` is not a superset of `filter.conditions`. We are doing the same in the rule `InferFiltersFromConstraints`: https://github.com/apache/spark/blob/master/sql/catalyst/src

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-22 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14661 cc @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-17 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/14661 This code change looks good to me. The logic in `` filter.constraints.filter(_.isInstanceOf[IsNotNull]) .exists(expr => join.left.outputSet.intersect(expr.references).nonEmpty)

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63833/ Test PASSed. ---

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14661 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14661 **[Test build #63833 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63833/consoleFull)** for PR 14661 at commit [`a537dd0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14661 **[Test build #63833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63833/consoleFull)** for PR 14661 at commit [`a537dd0`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #14661: [SPARK-16991][SQL] Fix Outer Join Elimination when Filte...

2016-08-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14661 cc @hvanhovell @yhuai @dongjoon-hyun @nsyca also cc the original reviewers: @davies @sameeragarwal @marmbrus Thanks! --- If your project is set up for it, you can reply to thi