[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-15 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14678 Thanks but also FYI this is not "minor". We should have a JIRA ticket for changes like this in the future. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-14 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14678 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65263/ Test PASSed. ---

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #65263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65263/consoleFull)** for PR 14678 at commit [`a26c08e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #65263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65263/consoleFull)** for PR 14678 at commit [`a26c08e`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14678 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14678 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-09-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14678 @cloud-fan Do you mind if I ask to take a look please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14678 ping @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14678 (@rxin cc you in case you just missed this) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63959/ Test PASSed. ---

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63959/consoleFull)** for PR 14678 at commit [`a26c08e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14678 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63959/consoleFull)** for PR 14678 at commit [`a26c08e`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14678 @gatorsmile Thanks for a very close look. I should've check the description of `PARALLEL_PARTITION_DISCOVERY_THRESHOLD`. --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14678 I checked the conf changes and the data types. It looks good to me. Only leave a minor comment on the conf description of one related parameter `PARALLEL_PARTITION_DISCOVERY_THRESHOLD`. Thanks!

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14678 nvm, I got the answer. We are unable to change them. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14678 Just searched the code and found more. Any reason why we do not change these? ``` ParquetFileFormat.scala:85:if (conf.get(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key) == null) {

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14678 Sure, will review it today. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63899/ Test PASSed. ---

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63899/consoleFull)** for PR 14678 at commit [`a57dd5e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/14678 Looks good, but I didn't look super carefully. @gatorsmile do you have time to take a more careful look at this? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14678 cc @rxin, Could you check if this make sense please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63899/consoleFull)** for PR 14678 at commit [`a57dd5e`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63898/consoleFull)** for PR 14678 at commit [`c959f3b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14678 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63898/ Test FAILed. ---

[GitHub] spark issue #14678: [MINOR][SQL] Add missing functions for some options in S...

2016-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14678 **[Test build #63898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63898/consoleFull)** for PR 14678 at commit [`c959f3b`](https://github.com/apache/spark/commit/c