Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14734
It was mostly manual -- I ran `dev/merge_spark_pr` and it prompted me to
say the cherry-pick has conflicts. I then opened another terminal and found
that the conflicts were in 3 files. I manually
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
tested with branch-2.0, looks good.
how did you merge it, btw?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14734
I just did the merge in
https://github.com/apache/spark/commit/b65b041af8b64413c7d460d4ea110b2044d6f36e
-- Will be great if you can run CRAN checks using this and make sure I didn't
miss anything
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
all the `\code{x}` changes are optional and do not affect CRAN check -
without those it might be easier
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14734
Hmm - let me give it a shot. If not I will open a fresh PR for `branch-2.0`
after doing a manual edit per file
---
If your project is set up for it, you can reply to this email and have your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
I tried cherry-picking this to branch-2.0 but merge was non-trivial -
should we merge manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14734
LGTM. I had a couple of minor comments inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14734
@junyangq Could you take one more look ? I will also do a pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
@shivaram any more thought? I'll merge since we should have this to be
ready for CRAN.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14734
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64164/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14734
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14734
**[Test build #64164 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64164/consoleFull)**
for PR 14734 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14734
**[Test build #64164 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64164/consoleFull)**
for PR 14734 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
`object 'C_runif' not found`
This is odd - the C function was [ported in
2012](https://github.com/wch/r-source/commit/e430853d37cda69505e7452ddceb06a2008821d2).
Changed to an
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14734
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14734
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64163/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14734
**[Test build #64163 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64163/consoleFull)**
for PR 14734 at commit
17 matches
Mail list logo
