[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14775 LGTM. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64585/ Test PASSed. ---

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64585/consoleFull)** for PR 14775 at commit [`d1ec80b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14775 Thanks @felixcheung - Addressed both the comments. Let me know if this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64585/consoleFull)** for PR 14775 at commit [`d1ec80b`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14775 github seems to like to hide stuff. FYI, this comment https://github.com/apache/spark/pull/14775#discussion_r76526025 and this https://github.com/apache/spark/pull/14775#discussion_r76526

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64540/ Test PASSed. ---

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64540/consoleFull)** for PR 14775 at commit [`448de0c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64539/ Test PASSed. ---

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64539/consoleFull)** for PR 14775 at commit [`0959208`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64540/consoleFull)** for PR 14775 at commit [`448de0c`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14775 @felixcheung Good point about having a wrapper -- That will make it easier to update the methods going forward. I added a new file `jvm.R` with the wrapper functions. --- If your project is set u

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64539/consoleFull)** for PR 14775 at commit [`0959208`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14775 I think the downside of naming them as-is and keeping the signature (`...` at the end) are that it would be very hard to change or add to the signature later on (say, to add a context/context_id

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64307/ Test PASSed. ---

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64307/consoleFull)** for PR 14775 at commit [`d267f2f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14775 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14775 cc @felixcheung @olarayej --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #14775: [SPARK-16581][SPARKR] Make JVM backend calling functions...

2016-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14775 **[Test build #64307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64307/consoleFull)** for PR 14775 at commit [`d267f2f`](https://github.com/apache/spark/commit/d