[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/14972 I'm OK with this not having a JIRA, and I agree the code path is tested sufficiently. (But wanting these is a good sentiment!) LGTM Merging with master --- If your project is set up for

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/14972 @hvanhovell Does 'ticket' mean jira? I think it may be too trivial to open one. There is already a test suite `MLSerDeSuite`. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14972 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14972 **[Test build #64990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64990/consoleFull)** for PR 14972 at commit

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14972 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64990/ Test PASSed. ---

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14972 @zhengruifeng could you still open a ticket for this? Could you also add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #14972: [Minor] Remove unnecessary check in MLSerDe

2016-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14972 **[Test build #64990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64990/consoleFull)** for PR 14972 at commit