Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15059
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65364/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65364/consoleFull)**
for PR 15059 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65363/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65363/consoleFull)**
for PR 15059 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65364/consoleFull)**
for PR 15059 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15059
@srowen I've reverted the previous change and inlined the relative
tolerance logic, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65363/consoleFull)**
for PR 15059 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15059
Yes in theory that's the thing to do, to have a series of increasingly
'core' modules but I think it's a bit late to undo the mono-core module design
here. Instead, maybe just for this test, it's OK
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15059
Oops, I found that ```ml.TestingUtils``` was located at ```mllib-local```
module and we can not move it to ```spark-core``` since ```mllib-local``` is
not intended to depend on other spark sub
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15059
@yanboliang Thank you! Will address your comment soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/15059
Yes @yanboliang is correct - we seem to have duplicated the double testing
between `ml` and `mllib`. I think we can get rid of it in `ml.TestingUtils`
also (but keep the vector/matrix stuff as it
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15059
Moving generic testing utils from mllib to common looks OK to me. Actually
we have ```TestingUtils``` under both spark.ml.util and spark.mllib.util. If we
would like to move, we should remove
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65306/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65306/consoleFull)**
for PR 15059 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15059
That seems reasonable to pull out some generic testing utils into common
from mllib. This looks OK to me. CC maybe @jkbradley ? @MLnick ? just anyone
for a second opinion.
---
If your project is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65306/consoleFull)**
for PR 15059 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15059
@srowen I've addressed your comment, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65265/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15059
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65265 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65265/consoleFull)**
for PR 15059 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15059
**[Test build #65265 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65265/consoleFull)**
for PR 15059 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15059
Oh I see. Yes if we can move it to Spark's core test module that would be
nicer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/15059
but relTol is defined in mllib and sql not reference it, seems better to
move it to spark-core project?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15059
We already have a 'relTol' operator for this purpose BTW.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
28 matches
Mail list logo
