[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 @gatorsmile , @hvanhovell . Yep. I knew the policy about new feature issues and bug fix issues. So, I wish this PR is considered as bug fix issue from the beginning. Ya, it's a new feature ind

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15168 @dongjoon-hyun the risk of this PR breaking something is quite low; so I am open to backporting as long as long as it does not create too much issues. BTW: did you open a backport? this was again

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 When implementing the native DDL support, we blocked a few DDL statements due to the resource limit. Thus, this PR is not a bug fix. In theory, we should not add new features into the previous re

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Thank you so much, @hvanhovell , @gatorsmile , and @skambha ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Oh, I see. Does that mean it's not allowed to be backported due to the policy although I made a patch for branch-2.0? --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-29 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15168 @dongjoon-hyun we made the decision to regress here willingly. So I think it is a new feature, also this is currently not backportable. LGTM. Merging to master. Thanks. --- If your proj

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . I thought it's a regression bug fix. I'm wondering if you think this is a new feature for Spark 2.1. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . Could you review this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Finally, it passed! @hvanhovell . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66001/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #66001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66001/consoleFull)** for PR 15168 at commit [`04c75e5`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65993/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65993/consoleFull)** for PR 15168 at commit [`fc132e6`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #66001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66001/consoleFull)** for PR 15168 at commit [`04c75e5`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65989/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65989/consoleFull)** for PR 15168 at commit [`2ed1069`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65988/consoleFull)** for PR 15168 at commit [`ec574ff`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65988/ Test FAILed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Now, the PR description is also up-to-date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65993/consoleFull)** for PR 15168 at commit [`fc132e6`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65989/consoleFull)** for PR 15168 at commit [`2ed1069`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65988/consoleFull)** for PR 15168 at commit [`ec574ff`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Never mind~. Thank you for coming back! I'll check the PR description again and make up-to-date. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15168 @dongjoon-hyun sorry about that. Is the PR description (including all the exceptions) up to date? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Oh, conflicts occurs due to https://github.com/apache/spark/pull/15234 . I'll resolve this soon. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . Could you review this PR again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . Could you review this PR again when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65903/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65903 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65903/consoleFull)** for PR 15168 at commit [`ea3c2c3`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65901/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65901/consoleFull)** for PR 15168 at commit [`095573c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65899/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65899/consoleFull)** for PR 15168 at commit [`d171bf6`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65903/consoleFull)** for PR 15168 at commit [`ea3c2c3`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65901/consoleFull)** for PR 15168 at commit [`095573c`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 I addressed those two comments. Thank you for thoughtful review, @gatorsmile ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 LGTM except two minor comments and pending tests. cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65899/consoleFull)** for PR 15168 at commit [`d171bf6`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 I see. I'll prevent that from those persistent views, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 I think we do not need an extra metastore call if we already know we do not support partitions over views. You can check all the other DDL implementation. We did the same thing. --- If your pro

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 For example, like the followings. ``` scala> sql("desc view1 partition (c='Us')").show org.apache.spark.sql.AnalysisException: Partition spec is invalid. The spec (c) must match the

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 If we are talking about hive views (for non-partitioned persistent view), there is no partition info because it looks like a normal table. So, my PR handles that equally with normal tables.

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 We do not need to support partitioned views, I think. Your PR is unable to handle it without a code change in `HiveClientImpl`. For non-partitioned persistent view, you should also issue

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Do you mean PartitionedView as you mentioned at #15233 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 How about the persistent view? I think we do not support it too, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65889/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65889/consoleFull)** for PR 15168 at commit [`c78ea7c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65889/consoleFull)** for PR 15168 at commit [`c78ea7c`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Definitely! Thank you, @gatorsmile . I added the logic to cover that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 This PR needs to cover more negative cases. Below is an example: ```Scala spark.range(10).select('id as 'a, 'id as 'b).createTempView("view1") sql("DESC view1 PARTITION (c='Us',

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Thank you for review @gatorsmile . Hi, @hvanhovell . Could you review this again? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65877/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65877/consoleFull)** for PR 15168 at commit [`21e8295`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65877/consoleFull)** for PR 15168 at commit [`21e8295`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Yep. That's would be great. Thank you for guidance always! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 Thank you for your investigation! How about generating a user-friendly error message in these unsupported cases? The error messages from Hive is very confusing to the external users. --- If you

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @gatorsmile . I investigated the related PRs. * #12934 `[SPARK-14127][SQL] Makes 'DESC [EXTENDED|FORMATTED] ' support data source tables` * #12844 `[SPARK-14127][SQL] Native

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 Partitioned View is another potential issue for this PR. FYI, just submitted a related PR https://github.com/apache/spark/pull/15168 --- If your project is set up for it, you can reply

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Sure. I'll investigate from that. Thank you for the pointer, @gatorsmile . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 Yeah, please change the JIRA to improvement. I did not check the code of Spark 1.6.2, but, since Spark 2.0, we provide a native support for `DESC TABLE`. See the PR: https://github.com/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Actually, I think there was a reason not to do that in Spark 1.6.2. In Spark 2.0, is there any new way to lookup the partition info from Parquet Datasource through `SessionCatalog`? `SessionCa

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 Yeah, I knew. : ) This PR is to support `DESCRIBE PARTITION`, right? The other `DESCRIBE` commands can support all the table types. Thus, I believe we need to support all the cases for `DESCRIBE

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @gatorsmile . It's the same behavior with Apache Spark 1.6.2. This PR doesn't make any regression for Datasource tables. Actually, the error you mentioned is raised by `HiveMetast

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Thank you, @gatorsmile . I'll fix that soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 It sounds like the implementation of this PR does not support data source tables. Please try the following example. ```Scala spark .range(1).select('id as 'a, 'id as

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65861/ Test PASSed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65861/consoleFull)** for PR 15168 at commit [`ba22975`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65861/consoleFull)** for PR 15168 at commit [`ba22975`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 The failure seems to be irrelevant. Retest this please. ``` [info] - Naive Bayes Multinomial *** FAILED *** (137 milliseconds) [info] Expected 0.7 and 0.6494565217391305 to be with

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65859/consoleFull)** for PR 15168 at commit [`ba22975`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65859/ Test FAILed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65859/consoleFull)** for PR 15168 at commit [`ba22975`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Oh, my bad. The only failure is `describe.sql`. We can not use `SQLQueryTestSuite` since the last access time is always different. ``` describe.sql *** FAILED *** (272 milliseconds)

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65841/ Test FAILed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65841/consoleFull)** for PR 15168 at commit [`f8fb269`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65842/ Test FAILed. ---

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15168 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65842/consoleFull)** for PR 15168 at commit [`c33af71`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Thank you, @gatorsmile . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15168 I also like this feature. The Hive-generated statistics for partitioned tables are stored in partition-level properties. See the PR: https://github.com/apache/spark/pull/15158 We definit

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . I updated the followings. - Add 'EXTENDED' and 'FORMATTED' description for 'PARTITION'. - Move the tests into SQLQueryTestSuite. `describe.sql`. Please note that the s

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65842/consoleFull)** for PR 15168 at commit [`c33af71`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15168 **[Test build #65841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65841/consoleFull)** for PR 15168 at commit [`f8fb269`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . Currently, `DESC FORMATTED TABLE` and `DESC EXTENDED TABLE` shows a little bit different from Apache Spark 1.6. I think it's improved a little. I'm revising the DETAIL/EX

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Thank you, @hvanhovell . Yes, currently, as you mentionedas `EXTEDNED` or `FORMATTED` is not included in this PR since I wasn't sure that Spark 2.0 want to fix this regression. Like S

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @hvanhovell . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #15168: [SPARK-17612][SQL] Support `DESCRIBE table PARTITION` SQ...

2016-09-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15168 Hi, @rxin . Could you review this PR to implement `DESCRIBE table PARTITION`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

  1   2   >