[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 Oh, BTW it seems `read.df` also seems not allowing this? I will try to test and fix here together if so. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 @felixcheung , I usually don't like to answer by quote but let me do this just to clarify. > Hmm, should we hold till 12601 is merged then? Seems like we shouldn't allow this unless

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15231 Hmm, should we hold till 12601 is merged then? Seems like we shouldn't allow this unless internal datasources are supporting this more broadly. Also, before the path parameter type is

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65880/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65880/ Test PASSed. ---

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 @felixcheung Yeap, I just added. As we don't currently have an internal datasource allowing `DataFrameWriter.save()` without a path, I just added a test with CSV data source to make sure it

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65880/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15231 Let's add some tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65868/ Test PASSed. ---

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65868/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65868/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65866/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65866/ Test FAILed. ---

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65866/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65865/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15231 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65865/ Test FAILed. ---

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 FWIW - Python API seems having `path` as optional[1] and Scala API seems doing this so as well[2]. [1]https://github.com/apache/spark/blob/master/python/pyspark/sql/readwriter.py#L521

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15231 **[Test build #65865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65865/consoleFull)** for PR 15231 at commit

[GitHub] spark issue #15231: [SPARK-17658][SPARKR] write.df API taking path optionall...

2016-09-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15231 cc @felixcheung and @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled