Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15232
**[Test build #65882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65882/consoleFull)**
for PR 15232 at commit
[`2e88804`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15232
**[Test build #65882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65882/consoleFull)**
for PR 15232 at commit
[`2e88804`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15232
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65882/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15232
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15232
you mean issue 224 of testthat on github? doesn't seem like it's related?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15232
change LGTM to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Oh I meant 244.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15232
According to this fix
https://github.com/hadley/testthat/commit/64036395cf0f2556cdd181dddb219e498f4be370
this is fixed in testthat v1.0.2? I recall we are running 1.1.0 in Jenkins?
---
If y
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Hm. Actually, I was wondering if it really works and I am still looking
here and there.
My `testthat` version in my local is `v.1.0.2`. but it seems not working as
below:
```r
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15232
It might be slightly different how `expect_error` would handle that, I was
more thinking
```
test_that('warning bug', options(warn = 2); warning('toto') )
```
should fail the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Sure, filed in https://issues.apache.org/jira/browse/SPARK-17674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
11 matches
Mail list logo
