Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
I'm closing this PR in favor of #15704 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Thank you, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15302
@dongjoon-hyun I'll take a look tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Hi, @hvanhovell .
I made another attempt #15704 by using 'Expression' as you commented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Hi, @hvanhovell .
In DDL, do we have an example to use `Expression` like this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
With today's master, it's like the following. Should we use expression in
`AlterTableDropPartitionCommand`?
```scala
org.apache.spark.sql.AnalysisException: cannot resolve '`country`' g
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Hi, @hvanhovell .
When using `Expression`, I faced two situations.
- `checkAnalysis` raises exceptions because the column is unresolved, e.g.,
`country` is unresolved.
- As a w
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
The only failure looks irrelevant. Anyway, I'm revising the PR.
```scala
[info] *** 1 SUITE ABORTED ***
[error] Error: Total 2604, Failed 0, Errors 1, Passed 2603, Ignored 48
[er
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66276/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66276/consoleFull)**
for PR 15302 at commit
[`3c0585b`](https://github.com/apache/spark/commit/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Thank you for the direction. I'll proceed to improve in that way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
I see. Then, how can evaluate the generic expression? Is it okay to use
'eval(null)'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15302
@dongjoon-hyun I think that `AlterTableDropPartitionCommand` just should
take a set of catalyst `Expression`s instead of a `PartitionRangeSpec`.
I have added a few things the `Catalog` bu
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Recently, I've watched you improved those related function greatly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Thank you for review, @hvanhovell ! Do you mean SQL grammar or
`listPartition`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15302
@dongjoon-hyun I have taken a quick look. Shouldn't we just use Expressions
for filtering partitions?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66276/consoleFull)**
for PR 15302 at commit
[`3c0585b`](https://github.com/apache/spark/commit/3
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Hi, @hvanhovell .
Could you give some opinion about this PR when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Hi, @hvanhovell .
Could you review this PR about 'ALTER TABLE DROP PARTITION'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66225/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66225/consoleFull)**
for PR 15302 at commit
[`eca9c86`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66225/consoleFull)**
for PR 15302 at commit
[`eca9c86`](https://github.com/apache/spark/commit/e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
The only failure is the following in `ColumnTypeSuite`. It's irrelevant and
the testsuite passed locally.
```
[info] - MAP append/extract *** FAILED *** (2 milliseconds)
[info] ja
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66219/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66219/consoleFull)**
for PR 15302 at commit
[`eca9c86`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66219/consoleFull)**
for PR 15302 at commit
[`eca9c86`](https://github.com/apache/spark/commit/e
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/15302
Rebased to the master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66130/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66130/consoleFull)**
for PR 15302 at commit
[`b59d622`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15302
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66123/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66123/consoleFull)**
for PR 15302 at commit
[`c6c52fe`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66130/consoleFull)**
for PR 15302 at commit
[`b59d622`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15302
**[Test build #66123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66123/consoleFull)**
for PR 15302 at commit
[`c6c52fe`](https://github.com/apache/spark/commit/c
39 matches
Mail list logo
