Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15338
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15338
no objections from me ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15338
The practical answer is that someone who can commit it has to want to
commit it, with nobody objecting. I can commit and am mildly in favor. I tend
to leave it open a day or two to let any
Github user mikejihbe commented on the issue:
https://github.com/apache/spark/pull/15338
Thanks for the input guys. I'm new to the community, so...I'm unfamiliar
with the process. Who makes the final decision here? I have a slight
preference to run with environment variables,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15338
Agree that env variables are not a great way to do anything, but that ship
has sailed. I don't think we'd remove the 10 that are already here, and if this
changed, would be a total rewrite. For that
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15338
You raise a good point about having to commit to support environment
variables in future versions. A command-line option would be preferable
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66969/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66969/consoleFull)**
for PR 15338 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66969/consoleFull)**
for PR 15338 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15338
LGTM. Let's see if @nchammas has some feedback. He had some very helpful
comments in #3881
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66770/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66770 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66770/consoleFull)**
for PR 15338 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66770/consoleFull)**
for PR 15338 at commit
Github user mikejihbe commented on the issue:
https://github.com/apache/spark/pull/15338
Thanks for the review @srowen. Those changes are in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66759/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66759/consoleFull)**
for PR 15338 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15338
**[Test build #66759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66759/consoleFull)**
for PR 15338 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15338
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15338
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
22 matches
Mail list logo
