Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
Submit a PR to fix the issues in my PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
Glad to see this being merged. Let me know if there is anything more I can
do to help with any issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15398
I pushed a commit. Hopefully that fixes it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ericl commented on the issue:
https://github.com/apache/spark/pull/15398
This seems to have broken the build in branch-2.1, e.g.
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-branch-2.1-compile-maven-hadoop-2.6/591/consoleFull
```
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15398
I've resolved the conflict and merged this in master/branch-2.1. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15398
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15398
Re-checked the current change, I think it is in a good shape. Do we have
unsolved issues or decisions on this?
ping @jodersky Would you like to update this with master? Thanks.
---
If
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/15398
Ping @jodersky, @rxin, @mengxr, @yhuai, @hvanhovell we also run into this
bug. Will be great we have it by 2.2 release. Thanks.
---
If your project is set up for it, you can reply to this email and
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15398
@mengxr, @rxin, @yhuai, @hvanhovell, what's the status of this PR? How much
works remains before this is good to go? What decisions are we blocking on? I
ask because this conflicts with a small
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69932/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #69932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69932/consoleFull)**
for PR 15398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #69932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69932/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
@hvanhovell, I just wanted to add that option 2 from my last comment won't
work: if we replace `\\` with `` in the unescape function (as is done for
`\%` and `\_`), it will be impossible for a
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
Also cc @hvanhovell who is the major reviewer about parser-related PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
> My question is more fundamental, why are SQL strings escaped in the first
place? Should it not be up to the frontend language to escape such strings?
I.e. scala/java/python should handle
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67478/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67478 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67478/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
@gatorsmile, I updated the PR according to your comments.
Whilst adding the example test
```scala
checkEvaluation("""%SystemDrive%\Users\John""" like
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67478/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
@gatorsmile thx for the review. I'll update the test suite as we discussed
initially :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
@jodersky Sorry. I misunderstood your point in the offline discussion.
After reading the codes, I think your original proposal is right. This PR needs
to clean up the test suite `LIKE literal
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15398
@jodersky I think the current approach is fine if we have documented it
clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67366/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67366/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
I went ahead and changed the parsing function to throw an AnalysisException
in case the input escaper sequence is invalid. Feel free to revert (or just
tell me and I'll do it) if we should stick
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67366/consoleFull)**
for PR 15398 at commit
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/15398
Thanks for checking the standard! I think that behavior is what most people
expect:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
FWIW, I just read this about the standard
> In an ANSI-compliant database, you can only use the LIKE escape character
to escape a percent sign ( % ), an underscore ( _ ), or the escape
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
I understand your comment about the weird escaping behaviour, @mengxr.
Putting myself into the shoes of a new user, I would be least surprised if
Spark were to treat the String verbatim (as in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67147/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67147/consoleFull)**
for PR 15398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #67147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67147/consoleFull)**
for PR 15398 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
I see. Agree. Will do an investigation with @jodersky Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15398
I think we should consider other databases behavior and see if our behavior
makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/15398
@jodersky Thank you for the patch! How about we add a summary related to
the behavior of escape in pr description and jira?
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15398
Also cc @yhuai and @JoshRosen @mengxr Please check whether the changes here
can satisfy what you want. Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
cc @viirya, I changed your original code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66561/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66561/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
Every non-java-pattern character is quoted now, updated the StringUtils
test suite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66561/consoleFull)**
for PR 15398 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66549/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66549/consoleFull)**
for PR 15398 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66552/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66552/consoleFull)**
for PR 15398 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66547/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15398
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66547/consoleFull)**
for PR 15398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66552/consoleFull)**
for PR 15398 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66549 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66549/consoleFull)**
for PR 15398 at commit
Github user jodersky commented on the issue:
https://github.com/apache/spark/pull/15398
I'll add some more tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15398
**[Test build #66547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66547/consoleFull)**
for PR 15398 at commit
59 matches
Mail list logo
