Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15484
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
ping @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
Does this version looks good now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68246/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #68246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68246/consoleFull)**
for PR 15484 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68245/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #68245 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68245/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #68246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68246/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #68245 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68245/consoleFull)**
for PR 15484 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
ping @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
What else should I update on this PR? Please don't be hesitate to require
any change, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user davies commented on the issue:
https://github.com/apache/spark/pull/15484
I see, this PR just improve the readability, we don't need to backport it,
looks good to me overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15484
It is not really a bug. Bitmap manipulation has bitten us quite a few time
in the past, so I would rather use expressions.
---
If your project is set up for it, you can reply to this email and
Github user davies commented on the issue:
https://github.com/apache/spark/pull/15484
@jiangxb1987 Could you say a little bit more about the "minor bug"? that
help us to decide this patch should be backported or not.
---
If your project is set up for it, you can reply to this email
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
@davies Would you please have a look at this PR? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67405/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67405 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67405/consoleFull)**
for PR 15484 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
@tejasapatil @rxin I've addressed most of your comments, thanks for
reviewing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67405/consoleFull)**
for PR 15484 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15484
cc @davies too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67325/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67325/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67325/consoleFull)**
for PR 15484 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67253/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67253/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #67253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67253/consoleFull)**
for PR 15484 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
@hvanhovell Thank you for your comments - They are awesome! I've made some
changes according to your advice, I hope the code looks better now. Thanks a
lot!
---
If your project is set up for
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15484
@hvanhovell Could you look at this please? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66967/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #66967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66967/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #66967 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66967/consoleFull)**
for PR 15484 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66960/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #66960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66960/consoleFull)**
for PR 15484 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15484
**[Test build #66960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66960/consoleFull)**
for PR 15484 at commit
41 matches
Mail list logo
