[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15523 Sure, @hvanhovell will do it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-03 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15523 Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-03 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15523 @gatorsmile can you open a PR for 2.0 if we also need to port it to that branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68045/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #68045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68045/consoleFull)** for PR 15523 at commit [`2364cc2`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-11-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #68045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68045/consoleFull)** for PR 15523 at commit [`2364cc2`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15523 LGTM and wait for @cloud-fan or others to do second check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67697/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67697/consoleFull)** for PR 15523 at commit [`49daace`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67697/consoleFull)** for PR 15523 at commit [`49daace`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-24 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15523 cc @cloud-fan @davies @sameeragarwal @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67457/consoleFull)** for PR 15523 at commit [`4f2101e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67457/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67457/consoleFull)** for PR 15523 at commit [`4f2101e`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67229/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67229/consoleFull)** for PR 15523 at commit [`52cb8fb`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67229/consoleFull)** for PR 15523 at commit [`52cb8fb`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15523 The parm name of the verification function is wrong. It should be `expectedNonNullableColumns`. Please check the test case again. --- If your project is set up for it, you can reply to this ema

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15523 @gatorsmile A predicate like `IsNotNull(a + b + Rand())` will let this change to wrongly set the nullability of `a` and `b` to true. Isn't it? --- If your project is set up for it, you can reply to

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67212/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67212 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67212/consoleFull)** for PR 15523 at commit [`ce418f9`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67212/consoleFull)** for PR 15523 at commit [`ce418f9`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15523 @viirya I have not changed the algorithm. I just tried to improve the test case coverage. Thanks to `constructIsNotNullConstraints`, the existing solution already covers all the cases,

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15523 cc @cloud-fan @davies @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67096/ Test PASSed. ---

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67096/consoleFull)** for PR 15523 at commit [`54c3cc8`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15523: [SPARK-17981] [SPARK-17957] [SQL] Fix Incorrect Nullabil...

2016-10-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15523 **[Test build #67096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67096/consoleFull)** for PR 15523 at commit [`54c3cc8`](https://github.com/apache/spark/commit/5