Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/15531
@srowen Unfortunately the 'Some' in the == is usually missed out, resulting
in bugs (and we have had a fair share of them in the past - some more severe
than others).
Given that there is no supp
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15531
Let the religious wars commence. If Option is a "collection of 0 or 1
things" then `.contains` at least makes some sense, if a bit obtuse. I still
think `== Some(x)` is clearer anyway.
---
If your
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15531
I disagree. It makes it very confusing, especially without explicit types,
to know what exactly is happening. Not everything should be a monad.
---
If your project is set up for it, you can reply to
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15531
@rxin Nonsense; it's just as good an idea as are List.contains and
Set.contains. The only problem with it is that it doesn't exist in Scala 2.10.
---
If your project is set up for it, you can
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15531
Hm we should ban Option.contains. It's not a good idea anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15531
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67118/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15531
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15531
**[Test build #67118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67118/consoleFull)**
for PR 15531 at commit
[`cd54a4b`](https://github.com/apache/spark/commit/
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/15531
We should ping the dev list for something like this.
For now, I am merging this fix. Compilation has passed in 2.11 in Jenkins,
and I locally compiled and tested in 2.10.
---
If your project is
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15531
Ha we have been bit by this like 3 times in the past month.
Time to begin agitating to remove 2.10 support.
---
If your project is set up for it, you can reply to this email and have your
reply a
10 matches
Mail list logo
